fix(feedback): fix patching flakes with test_openai.py #95577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmanallen
approved these changes
Jul 15, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## master #95577 +/- ##
==========================================
- Coverage 80.82% 80.82% -0.01%
==========================================
Files 10547 10547
Lines 607945 607965 +20
Branches 23825 23825
==========================================
+ Hits 491384 491394 +10
- Misses 115852 115862 +10
Partials 709 709 |
ah good to know, what if it's done in a fixture like |
|
wow, I was facing this exact issue when I was trying to test feedback summaries - thanks for cleaning it up |
aliu39
added a commit
that referenced
this pull request
Jul 17, 2025
#95392) User reports are the same product as feedback and owned by replay team. I'd like to move the code here for organizational purposes. Same goes for the feedback summary endpoint. This PR only moves things around, no implementation changes. Ref [REPLAY-513: \[PR Tracker\] refactor backend user feedback code](https://linear.app/getsentry/issue/REPLAY-513/pr-tracker-refactor-backend-user-feedback-code) I plan to follow up with quality improvements to the ingest functions, making them more composable, so that module's subject to change. Also fixes a flaky test `test_openai` described in #95577
cursor bot
pushed a commit
that referenced
this pull request
Jul 18, 2025
Discovered in #95392 the monkeypatching of `OpenAI` class in `test_create_feedback.py` can affect `test_openai.py`, I'm guessing when they are ran in parallel. I haven't seen this flake anywhere else, but don't believe it's related to the changes in #95392. Using the patch context manager should fix this. "not spam" return value bleeds over to the openai test: <img width="806" height="476" alt="Screenshot 2025-07-15 at 10 51 22 AM" src="https://github.com/user-attachments/assets/d900d7d1-9138-422f-b354-ac94fad9967a" /> Ref [REPLAY-513: [PR Tracker] refactor backend user feedback code](https://linear.app/getsentry/issue/REPLAY-513/pr-tracker-refactor-backend-user-feedback-code)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered in #95392 the monkeypatching of
OpenAIclass intest_create_feedback.pycan affecttest_openai.py, I'm guessing when they are ran in parallel. I haven't seen this flake anywhere else, but don't believe it's related to the changes in #95392. Using the patch context manager should fix this."not spam" return value bleeds over to the openai test:
Ref REPLAY-513: [PR Tracker] refactor backend user feedback code